Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Sentry: Change stream that is used during check #25759

Merged

Conversation

arsenlosenko
Copy link
Contributor

What

Fix issue during check in case if events stream is empty

How

use ProjectDetail stream

@arsenlosenko arsenlosenko requested a review from bazarnov May 2, 2023 11:15
@arsenlosenko arsenlosenko self-assigned this May 2, 2023
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/sentry labels May 2, 2023
@arsenlosenko
Copy link
Contributor Author

arsenlosenko commented May 2, 2023

/test connector=connectors/source-sentry

🕑 connectors/source-sentry https://github.com/airbytehq/airbyte/actions/runs/4860572412
❌ connectors/source-sentry https://github.com/airbytehq/airbyte/actions/runs/4860572412
🐛 https://gradle.com/s/3lxordheckeeo

Build Failed

Test summary info:

Could not find result summary

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
  • You, or an Airbyter, have run /publish successfully on this PR - or on a non-forked branch
  • You've updated the connector's metadata.yaml file (new!)
  • The Octavia bot updated the source_definitions.yaml or destination_definitions.yaml, or you ran processResources manually (deprecated)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@arsenlosenko
Copy link
Contributor Author

arsenlosenko commented May 2, 2023

/test connector=connectors/source-sentry

🕑 connectors/source-sentry https://github.com/airbytehq/airbyte/actions/runs/4860667891
✅ connectors/source-sentry https://github.com/airbytehq/airbyte/actions/runs/4860667891
Python tests coverage:

Name                        Stmts   Miss  Cover
-----------------------------------------------
source_sentry/source.py        18      0   100%
source_sentry/__init__.py       2      0   100%
source_sentry/streams.py      109     16    85%
-----------------------------------------------
TOTAL                         129     16    88%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
=================== 39 passed, 2 skipped in 68.29s (0:01:08) ===================

@arsenlosenko
Copy link
Contributor Author

arsenlosenko commented May 2, 2023

/publish connector=connectors/source-sentry

🕑 Publishing the following connectors:
connectors/source-sentry
https://github.com/airbytehq/airbyte/actions/runs/4860737301


Connector Version Did it publish? Were definitions generated?
connectors/source-sentry 0.2.2

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@arsenlosenko arsenlosenko merged commit a354378 into master May 2, 2023
20 checks passed
@arsenlosenko arsenlosenko deleted the arsenlosenko/source-sentry-fix-check-with-no-records branch May 2, 2023 12:12
marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
* Source Sentry: Change stream that is used during check

* Update changelog

* Update metadata.yaml

* Remove import

* auto-bump connector version

---------

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/sentry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants